On 01/29/2013 12:19 PM, Tom Warren wrote:
> Note that T114 does not have a separate/different DVC (power I2C)
> controller like T20 - all 5 I2C controllers are identical, but
> I2C5 is used to designate the controller intended for power
> control (PWR_I2C in the schematics).
>
> Signed-off-by: Tom Warren <twar...@nvidia.com>
> ---
> arch/arm/dts/tegra114.dtsi | 93
> +++++++++++++++++++++++++++++++++
> board/nvidia/dts/tegra114-dalmore.dts | 33 ++++++++++++
> 2 files changed, 126 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi
> index d06cd12..76fc83b 100644
> --- a/arch/arm/dts/tegra114.dtsi
> +++ b/arch/arm/dts/tegra114.dtsi
> @@ -2,4 +2,97 @@
>
> / {
> compatible = "nvidia,tegra114";
> +
> + tegra_car: clock@60006000 {
> + compatible = "nvidia,tegra114-car", "nvidia,tegra20-car";
I don't believe the Tegra114 CAR is backwards-compatible enough with
Tegra20 to include the Tegra20 entry in compatible. In other words, just:
compatible = "nvidia,tegra114-car";
> + reg = <0x60006000 0x1000>;
> + #clock-cells = <1>;
> + };
> + apbdma: dma {
> + compatible = "nvidia,tegra114-apbdma", "nvidia,tegra20-apbdma";
Same here; it isn't fully backwards-compatible according to Laxman's
kernel patches.
I don't think you need the APB DMA node for I2C though; perhaps just
drop it.
If you do keep this node, it needs the clocks property filled in.
> + i2c@7000c000 {
> + compatible = "nvidia,tegra114-i2c", "nvidia,tegra20-i2c";
The I2C nodes also aren't backwards-compatible.
> + reg = <0x7000c000 0x100>;
The interrupts property is missing here.
> diff --git a/board/nvidia/dts/tegra114-dalmore.dts
> b/board/nvidia/dts/tegra114-dalmore.dts
Board changes would usually be a separate patch to an SoC change, but I
guess not a big deal.
All 5 I2C ports are used on the board and only support 100KHz? That
seems unusual, but I suppose it's possible.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
