-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/19/2013 04:29 PM, Julius Werner wrote: > Hi Tom, > > This patch is not really target specific, it works on all platforms > that support USB 2.0. I just wrapped it in a new config option > because most people probably won't need it… it is only really > useful for hardware verification, so I figured whoever needs it can > hack in the config option himself. However, I could also just > remove the #ifdef and activate it by default if you prefer that. No > new code will get executed unless you type the new command, so it > should not have any negative effect besides a negligible code size > increase.
Well, we should enable it at least on the board config you've tested the code with, and you can show how negligible the size difference is. The point is that adding code that's not enabled somewhere leads to bitrot. Thanks! - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRI/rVAAoJENk4IS6UOR1W5yoP/jA1KZaqH/1a+uiF4TkMhOqO 1ureFhSUBG875EqnqJsjdGgYt/SZfwBtku5i+qZDtE5jAN6KpPOEV4grRUAYhWll dWpb503TK9Ow+sJKYk8KF+k+awyMwt60L2gZEYxtl2C8ZCGiC6MzEmA25W24pBKh Vj3g6Sg5tgoFPWFBFFXtP3UNgcIzDrmSE4UJzyzKXInap4dwHt+b6Z6EwZ4+iQ6t ekNYxMlEVgdmw2KeuGmDlvjQpmVpaavMYCEON6NbUuCeg830555ETxzC/k37obDq K+PPITocXiR6dm8J42nBA1kaoaG58oRLjCSFlPogVxQ/VdtuAf2RhX9MOBofBw4j VdyV4d90rTCMHdKqids71gdB2YxqkIVdschN7jjpeNHDUEk54dVB5dAW49UJmxhD SWMF03YAfM055W4F0h2CsoZHr/hYqRwDo2J3ljazCAAsSfYav0kdaI6HzZI1zFmd hjs+ThO3A3Ek+lGsSx3Gh0JKKGv/FyfstnrFMVpF098SNkblN7WP7BmCTcWD6ARq h+GecKlSnguzuOVkDjuLCLgJnPVLY2m4D9ixaTuVMGDgNyFCiC4n/TRamHgG7duW HgEyni0hgk3dV3YV9olFeNPaZv0DW+iF0dkQeUI61KfDl8Xi/2Vc4b0ds53NJQmQ fR0w3/FsjQbksD2/aGac =eCCl -----END PGP SIGNATURE----- _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
