Dear egbert.e...@googlemail.com,
In message <1364285735-2364-2-git-send-email-egbert.e...@gmail.com> you wrote:
> From: Egbert Eich <e...@suse.com>
>
> Disks beyond 2T in size use blocksizes of 4096 bytes. However a lot of
> code in u-boot still assumes a 512 byte blocksize.
>
> Signed-off-by: Egbert Eich <e...@suse.com>
> ---
> disk/part_efi.c | 32 ++++++++++++++++----------------
> include/common.h | 10 ++++++++--
> include/part.h | 3 +++
> include/part_efi.h | 2 --
> 4 files changed, 27 insertions(+), 20 deletions(-)
WARNING: line over 80 characters
#192: FILE: disk/part_efi.c:463:
+ gpt_header *gpt_h = calloc(1, PAD_TO_BLOCKSIZE(sizeof(gpt_header),
dev_desc));
WARNING: line over 80 characters
#199: FILE: disk/part_efi.c:469:
+ gpt_entry *gpt_e = calloc(1, PAD_TO_BLOCKSIZE(GPT_ENTRY_NUMBERS *
sizeof(gpt_entry), dev_desc));
WARNING: line over 80 characters
#217: FILE: disk/part_efi.c:670:
+ pte = memalign(ARCH_DMA_MINALIGN,
PAD_TO_BLOCKSIZE(count,dev_desc));
ERROR: space required after that ',' (ctx:VxV)
#217: FILE: disk/part_efi.c:670:
+ pte = memalign(ARCH_DMA_MINALIGN,
PAD_TO_BLOCKSIZE(count,dev_desc));
^
WARNING: line over 80 characters
#248: FILE: include/common.h:996:
+ char __##name[ROUND(PAD_SIZE(size * sizeof(type),pad), align) + (align
- 1)]; \
ERROR: space required after that ',' (ctx:VxV)
#248: FILE: include/common.h:996:
+ char __##name[ROUND(PAD_SIZE(size * sizeof(type),pad), align) + (align
- 1)]; \
^
WARNING: line over 80 characters
#267: FILE: include/part.h:59:
+#define PAD_TO_BLOCKSIZE(size, block_dev_desc) (PAD_SIZE(size,
block_dev_desc->blksz))
total: 2 errors, 5 warnings, 146 lines checked
/home/wd/Mail/U-Boot/7149 has style problems, please review.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I wish Captain Vimes were here. He wouldn't have known what to do
either, but he's got a much better vocabulary to be baffled in.
- Terry Pratchett, _Guards! Guards!_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
