Dear Fabio Estevam, [..]
> >> Shouldn't this function be placed into a common mx5 location? mx53ard > >> uses the same. > > > > The WEIM and M4IF configuration is board-specific. > > Right, understood. It seems like a duplication of code from mx53ard, > but anyway, what about: > > clrbits_le32(WEIM_BASE_ADDR + i, WEIM_GCR2_MUX16_BYP_GRANT) ? > > Accessing registers via offsets is not the best practice in U-boot. > > What about the weim struct defined at > arch/arm/include/asm/arch-mx5/imx-regs.h > > for acessing such registers? Yes, I agree, but you won't be able to do that in a loop as above if accessed via struct-based access so I'm keeping this. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
