On Fri, Apr 26, 2013 at 04:02:29PM +0800, Kuo-Jung Su wrote: > From: Kuo-Jung Su <dant...@faraday-tech.com> > > To: u-boot@lists.denx.de > CC: Albert Aribaud <albert.u.b...@aribaud.net> > > These patches introduce Faraday A36x SoC platform support. > > Here are some public documents for your reference. > > http://www.faraday-tech.com/html/documentation/index.html > > There is also a A369 QEMU emulator available at my github account: > > https://github.com/dantesu1218/qemu.git > > Here is quick start for QEMU: > > 1. Download the QEMU source tree > > $ git clone -b qemu-1.3.0 https://github.com/dantesu1218/qemu.git > > 2. Build & Install the QEMU: > > $ ./configure --target-list=arm-softmmu > $ make > $ make install > > 3. Launch u-boot with QEMU: > > $ qemu-system-arm -M a369 -m 512M -nographic -kernel ~/u-boot-devel/u-boot > > Changes for v3: > - Coding Style cleanup. > There is still one warnning reported by checkpatch.pl, > however it's too deep for me to fix it. > Here is the shapshot for it: > ----------------------------------------------------- > WARNING: do not add new typedefs > #9735: FILE: include/lcd.h:258: > +typedef struct vidinfo { > ----------------------------------------------------- > - Drop bit fields from c struct. > - Drop macros for wirtel()/readl(), call them directly. > - Always insert a blank line between declarations and code. > - Replace all the infinite wait loop with a timeout. > - Add '__iomem' to all the declaration of HW register pointers. > - cmd_boot.c: Make it a separate stand-alone patch. > - ftspi020: Make it a separate stand-alone patch. > - dma-mapping.h: Have the global data ptr declared outside functions. > - dma-mapping.h: Add #if...#else...#endif to dma_free_coherent(). > - MMU/D-Cache: Drop static non-cached region, now we use > map_physmem()/unmap_physmem() for dynamic mappings. > - ftmac110: Make a correction to multi-line comment style > - ftmac110: Use random MAC address while having trouble > to get one from environment variables. > - ftmac110: Add comments to timing control registers. > - ftnandc021: Re-write this driver with ECC enabled and > correct column address handling for OOB read/write, > and fixing issused addressed by Scott. > - a36x_config: No more static global network configurations. > - a36x_config: Add a common file for the redundant configurations.
I see a few: /* -------------------- * Comment */ in various places, and I pointed it out in the net changes, but I also saw in the SPI block '100' being used as a timeout, rather than defined. Please give everything a check for magic numbers and direct numbers used as timeout, rather than a #define. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot