Dear Sascha Silbe, In message <1372195668-25496-4-git-send-email-t-ub...@infra-silbe.de> you wrote: > The GPIO support of Dove is very similar to that on Kirkwood (and > possibly orion5x as well). Instead of duplicating the code, we tweak > the Kirkwood driver so it works for Dove, too.
This throws a number of checkpatch warnings and errors (line over 80 characters, code indent should use tabs where possible, please, no spaces at the start of a line). Please fix. > -/* > - * Based on (mostly copied from) plat-orion based Linux 2.6 kernel driver. > - * Removed kernel level irq handling. Took some macros from kernel to > - * allow build. > - * > - * Dieter Kiermaier dk-arm-li...@gmx.de > - */ Please never, never ever remove existing Copyright information or information about the origin of the code. This is a strong NAK. > index cd1bc00..7e35833 100644 > --- a/arch/arm/include/asm/arch-kirkwood/gpio.h > +++ b/include/kw_gpio.h > @@ -1,5 +1,7 @@ > /* > - * arch/asm-arm/mach-kirkwood/include/mach/gpio.h > + * Marvell Dove and Kirkwood SoCs common gpio > + * > + * Sebastian Hesselbarth <sebastian.hesselba...@gmail.com> Which purpose has the mentioning of this name here? If this is supposed to be a copyright claim, it should say so. > - * Based on (mostly copied from) plat-orion based Linux 2.6 kernel driver. > - * Removed kernel level irq handling. Took some macros from kernel to > - * allow build. > - * > - * Dieter Kiermaier dk-arm-li...@gmx.de Again, this gets dropped. All these changes look pretty much fishy to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de People seldom know what they want until you give them what they ask for. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot