Hi Axel, On Sat, 15 Jun 2013 17:10:38 +0800, Axel Lin <axel....@ingics.com> wrote:
> The implementation of gpio_is_valid() has inversed logic, fix it. > > Signed-off-by: Axel Lin <axel....@ingics.com> > --- > Hi, > I don't have this hardware to test, but current code looks obviously wrong. > I'd appreciate if someone can review and test this patch. > > Axel > drivers/gpio/altera_pio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Not sure why this was assigned to me, as this is not ARM related. Delegating to Thomas Chou as the NIOS(II) custodian and Cc:ing him, as well as Scott McNutt, nios2-generic maintainer. > diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c > index fb03760..7ab6df8 100644 > --- a/drivers/gpio/altera_pio.c > +++ b/drivers/gpio/altera_pio.c > @@ -294,6 +294,6 @@ int gpio_is_valid(int number) > int gidx = altera_pio_gidx(number); > > if (gidx < 0) > - return 1; > - return 0; > + return 0; > + return 1; > } Amicalement, -- Albert. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
