> On Saturday 04 April 2009 09:39:14 Wolfgang Denk wrote: >> In message Mike Frysinger wrote: >> > From: Todor I Mollov <tmol...@ucsd.edu> >> > >> > Signed-off-by: Todor I Mollov <tmol...@ucsd.edu> >> > Signed-off-by: Mike Frysinger <vap...@gentoo.org> >> > CC: Haavard Skinnemoen <haavard.skinnem...@atmel.com> >> > --- >> > drivers/mtd/spi/atmel.c | 139 >> > +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 139 >> > insertions(+), 0 deletions(-) >> >> I understand this is not a bug fix but new stuff, i. e. for the next >> release? > > correct. i'm posting it for feedback in case someone notices a problem, > or > the atmel guys want something different. i'll keep it in my sf branch for > next release so it doesnt get lost. > -mike >
Sorry for the terminology mix-up there. I guess I labeled it as a bug fix since, prior to the patch, attempting to write or erase and at45 flash in powers-of-two mode caused u-boot to crash due to null function pointer call. In my head things that lead to crashes get labeled as bugs. This occurred in both 2009.01 and 2009.03. It would probably be a good idea to implement a check in the upper level of the spi flash driver to handle such issues and report them gracefully ;). (It definitely left me scratching my head for a while there until I familiarized myself with the driver structure a bit.) -Todor _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
