On Tue, Jul 30, 2013 at 8:36 PM, Marek Vasut <ma...@denx.de> wrote: > Dear Otavio Salvador, > >> On Tue, Jul 30, 2013 at 7:46 PM, Marek Vasut <ma...@denx.de> wrote: >> > Dear Otavio Salvador, >> > >> > [...] >> > >> >> > + mxsfb_write_register(0x36, 0xaf); >> >> > + mxsfb_write_register(0x37, 0); >> >> > + mxsfb_write_register(0x38, 0xdb); >> >> > + mxsfb_write_register(0x39, 0); >> >> > + mxsfb_write_register(0x20, 0); >> >> > + mxsfb_write_register(0x21, 0); >> >> > + /* Turn on Framebuffer Upload Mode */ >> >> > + mxsfb_write_byte(0x22, 0); >> >> >> >> Where does those values come from? >> > >> > The panel datasheet and from Amaury. >> > >> > [...] >> > >> > It'd be nice if you learnt to cut down the email to the relevant part >> > only when replying. >> >> Couldn't this use macros to make it easier to read > > What kind of macros ? Using function call allows the compiler to do type- > checking on the data, so no, using macro would be sub-par. > >> or at least a >> comment informing where to find those? > > See OTM2201A datasheet for the finer details, yet it will be useless for you > since this is rather device-specific configuration.
A comment giving the datasheet name where those were took would be good. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
