Hi, Thank you for your review.
2013/7/31 Michal Simek <mon...@monstr.eu>: > On 07/31/2013 09:43 AM, Nobuhiro Iwamatsu wrote: >> Add support for Spansion S25FL512S_256K SPI flash. >> >> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu...@renesas.com> >> --- >> drivers/mtd/spi/spansion.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c >> index 47a4897..a7dc096 100644 >> --- a/drivers/mtd/spi/spansion.c >> +++ b/drivers/mtd/spi/spansion.c >> @@ -1,4 +1,5 @@ >> /* >> + * Copyright (C) 2013 Renesas Electronics Corporation > > I don't think that this is huge contribution that you should also update > header. > Hm, OK. I remove this line. >> * Copyright (C) 2009 Freescale Semiconductor, Inc. >> * >> * Author: Mingkai Hu (mingkai...@freescale.com) >> @@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params >> spansion_spi_flash_table[] = { >> .nr_sectors = 1024, >> .name = "S25FL512S_64K", >> }, >> + { >> + .idcode1 = 0x0220, >> + .idcode2 = 0x4d00, >> + .pages_per_sector = 1024, >> + .nr_sectors = 256, >> + .name = "S25FL512S_256K", >> + }, > > Jagan sent very similar patch > http://lists.denx.de/pipermail/u-boot/2013-May/155501.html > but nr_sectors and pages_per_sector are swapped. I did not notice this patch, thanks. I wait patch of Jagan to be merged. Best regards, Nobuhiro > > Thanks, > Michal > > -- > Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 > w: www.monstr.eu p: +42-0-721842854 > Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ > Maintainer of Linux kernel - Xilinx Zynq ARM architecture > Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform > > > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > -- Nobuhiro Iwamatsu _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot