Dear Julius Werner, > > Why 8 * 1000? It's not clear. > > I am not quite sure to be honest... it's been a while since I actually > wrote this patch. The EHCI spec gives no clear max for the > Periodic/Async Schedule disable (I assume not more than a frame, > though), and says the Run/Stop bit must halt within 16 microframes > (which would be 4.125ms). I guess 8 looked like a safe and not too > large value that still makes the line fit on 80 characters (and it's > not like most of the other timeouts in that file have a clear origin, > so it's in good company). What do you want me to change it to?
I would like to hear a convincing argument why 8 is the good value. The amount of "I guess" in the text above does not convince me. It would be also good if you didn't sprinkle duplicates of this magic value all around , but instead #define it somewhere and put a beefy comment above it. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
