On Mon, Sep 30, 2013 at 08:37:56AM +0200, Stefan Roese wrote: > Hi Tom, > > On 27.09.2013 21:26, Tom Rini wrote: > > Add a new symbol, CONFIG_SPL_BOOTCOUNT_SUPPORT, to make use of the > > existing BOOTCOUNT_SUPPORT within SPL. It is strongly discouraged to > > use bootcount in both SPL and full U-Boot, as they use the same counter. > > I just noticed that I missed sending the SPL bootcount implementation I > did a few weeks ago to the list. I'll send it shortly. The main > differences I see right now are: > > - My implementation requires CONFIG_BOOTCOUNT_LIMIT and > CONFIG_SPL_BOOTCOUNT_SUPPORT to be configured
OK, I see where you went with this, and I like this idea better. I shall incorporate that in v2. > - The check is not added to the board-specific code, but the > medium code (here spl_nor.c). This might be consolidated even > more by moving it to a non-boot-medium specific location (spl.c)? This I think takes things the wrong way. When it's part of spl_start_uboot we cover all boot method cases (MMC and NAND, in my case). Perhaps we should switch to a useful, but still weak default function? -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot