On Fri, Oct 04, 2013 at 20:21 +0530, Sourav Poddar wrote:
>
> diff --git a/drivers/mtd/spi/sf_ops.c b/drivers/mtd/spi/sf_ops.c
> index c009af5..bee4128 100644
> --- a/drivers/mtd/spi/sf_ops.c
> +++ b/drivers/mtd/spi/sf_ops.c
> @@ -269,7 +269,9 @@ int spi_flash_cmd_read_ops(struct spi_flash *flash, u32
> offset,
>
> /* Handle memory-mapped SPI */
> if (flash->memory_map) {
> + spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MEM_MAP);
> memcpy(data, flash->memory_map + offset, len);
> + spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MEM_MAP);
> return 0;
> }
Feedback has been sent before, but I'm afraid the motivation
wasn't received appropriately.
Shouldn't the memcpy() call be surrounded by _MAP and _MAP_END
(please note the _END in the second spi_xfer() invocation)? The
current patch doesn't "close" the transfer, which appears to pass
tests but isn't correct.
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
