On Sat, Oct 05, 2013 at 09:49:41PM +0200, Wolfgang Denk wrote: > Dear Simon, > > with commit a8f6ab5 "fs: Add support for saving data to filesystems" > you add the function do_save() to U-Boot. This includes the following > code (line numbers as of current master): > > "fs/fs.c": > > ... > 331 filename = argv[3]; > 332 addr = simple_strtoul(argv[4], NULL, cmdline_base); > 333 bytes = simple_strtoul(argv[5], NULL, cmdline_base); > 334 if (argc >= 7) > 335 pos = simple_strtoul(argv[6], NULL, cmdline_base); > 336 else > 337 pos = 0; > > > Should we not perform at least minimal error checking, i. e. verify > that no garbage arguments have been passed to that function?
Yes, we ought to. If you don't pass fatwrite the right number of arguments we get data aborts, for example. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
