> From: Scott Wood [mailto:scottw...@freescale.com] > On Thu, 2013-10-10 at 16:30 +0530, Pekon Gupta wrote: [snip] > > -#else > > + } else { > > /* > > * This ecc_size_config setting is for BCH sw library. > > * > > @@ -333,7 +330,7 @@ static void omap_hwecc_init_bch(struct nand_chip > *chip, int32_t mode) > > * size1 = 32 (skip 32 nibbles = 16 bytes per sector in spare area) > > */ > > val = (32 << 22) | (0 << 12); > > -#endif > > + } > > Either indentation or braces are wrong above. If it's just the > indentation that's wrong, let me know and I can fix up when applying. > Yes, thanks. I did run checkpatch.pl but may be because code here is not part of the changed lines, so it did not give the indentation warning.
> > +/** > > + * omap_select_ecc_scheme - configures driver for particular ecc-scheme > > + * @nand: NAND chip device structure > > + * @ecc_scheme: ecc scheme to configure > > + * @pagesize: number of main-area bytes per page of NAND device > > + * @oobsize: number of OOB/spare bytes per page of NAND device > > + */ > > +static int omap_select_ecc_scheme(struct nand_chip *nand, > > + enum omap_ecc ecc_scheme, unsigned int pagesize, unsigned int > oobsize) { > > Brace goes on its own line for function definitions. Again, I can fix > this while applying. > Yes please if you can fix this while applying it would be helpful. Sorry But here also I din't get the any warning from checkpatch.pl. But I remember checkpatch used to check this rule earlier. ------------- $linux_mainline/scripts/checkpatch.pl --strict \ tmp/0001-mtd-nand-omap-enable-BCH-ECC-scheme-using-ELM-for-ge.patch total: 0 errors, 0 warnings, 0 checks, 580 lines checked NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO\ MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE ----------------- Do we have any checkpatch utility for u-boot ? Thank You for help. with regards, pekon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot