Hi Stefano,

> Hi Marek,
> 
> On 02/11/2013 18:23, Marek Vasut wrote:
> > +                   if (!timeout) {
> > +                           debug("MXS I2C: Failed receiving data!\n");
> > +                           return -EINVAL;
> > +                   }
> > +
> 
> This is a real error and not a debug information. IMHO it should be
> better to print the error unconditionally with puts/printf, reporting
> that the timer elapsed.

Returning -EINVAL will make the i2c stack trigger an output, so having it 
duplicated here is pointless I believe.

Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to