Hi Giuseppe, On 07/11/2013 11:41, Giuseppe Pagano wrote:
> Sorry, I used vim and imported patch as a file in evolution, I > understood too late that I also need to change Format from "normal" to > "preformatted". In the future I will use "git send-email". > Ok >> >> Please take a look at the rules to submit patches : >> >> http://www.denx.de/wiki/U-Boot/Patches > > Sure, I read it, nevertheless I made lots of errors. This was my first > submit..sorry No problem ;-) > >> Do not fix multiple issues in the same patch if not strictly needed. The >> commit message is misleading: you say you are moving the configuration >> files, but they are not moved (they can't because they belong to >> nitrogen) and new files are generated. > > Maybe I was wrong in writing "move configuration files.." > > I think [PATCH 0/4] can be consider an atomical change: Fabio first uDoo > support adopt nitrogenx register setting for DDR3, clock, muxing, etc > > uDoo schematics is rather different from nitrogen6x, and it needs > customized setting for most of the register (as every platform). It > takes too long describe every single new setting. > Previous configuration was very unstable and adopting those settings > uDoo board has frequently crash. Ok - this is an explanation that can be simply added to the commit message. >> If you make change to a board, you should send your patches in CC to the >> board maintainer, too (for udoo, Fabio: I put him in CC). > > Fabio was abreast of this changes, but not in cc. I'll use CC in next > post. > Thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot