Hi Giuseppe,
On 11/11/2013 18:11, Giuseppe Pagano wrote:
> Add Ethernet and networking support on uDoo board (FEC + phy Micrel KSZ9031).
>
> Signed-off-by: Giuseppe Pagano <giuseppe.pag...@seco.com>
> CC: Stefano Babic <sba...@denx.de>
> CC: Fabio Estevam <fabio.este...@freescale.com>
> ---
ok - remember to increment the version number of the patchset for next
time (this is really V2 instead of V1).
> board/udoo/udoo.c | 140
> ++++++++++++++++++++++++++++++++++++++++++++++++
> include/configs/udoo.h | 16 ++++++
> include/micrel.h | 5 ++
> 3 files changed, 161 insertions(+)
>
> diff --git a/board/udoo/udoo.c b/board/udoo/udoo.c
> index e9d6375..ca49ebb 100644
> --- a/board/udoo/udoo.c
> +++ b/board/udoo/udoo.c
> @@ -9,6 +9,7 @@
> #include <asm/arch/clock.h>
> #include <asm/arch/imx-regs.h>
> #include <asm/arch/iomux.h>
> +#include <malloc.h>
> #include <asm/arch/mx6-pins.h>
> #include <asm/errno.h>
> #include <asm/gpio.h>
> @@ -18,6 +19,9 @@
> #include <asm/arch/crm_regs.h>
> #include <asm/io.h>
> #include <asm/arch/sys_proto.h>
> +#include <micrel.h>
> +#include <miiphy.h>
> +#include <netdev.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -25,6 +29,9 @@ DECLARE_GLOBAL_DATA_PTR;
> PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | \
> PAD_CTL_SRE_FAST | PAD_CTL_HYS)
>
> +#define ENET_PAD_CTRL (PAD_CTL_PUS_100K_UP | \
> + PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | PAD_CTL_HYS)
> +
> #define USDHC_PAD_CTRL (PAD_CTL_PUS_47K_UP | \
> PAD_CTL_SPEED_LOW | PAD_CTL_DSE_80ohm | \
> PAD_CTL_SRE_FAST | PAD_CTL_HYS)
> @@ -58,6 +65,99 @@ static iomux_v3_cfg_t const wdog_pads[] = {
> MX6_PAD_EIM_D19__GPIO_3_19,
> };
>
> +int mx6_rgmii_rework(struct phy_device *phydev)
> +{
> + /*
> + * Bug: Apparently uDoo does not works with Gigabit switches...
> + * Limiting speed to 10/100Mbps, and setting master mode, seems to
> + * be the only way to have a successfull PHY auto negotiation.
> + * How to fix: Understand why Linux kernel do not have this issue.
> + */
Fine. This is ok, but could you also add to the commit message that
Ethernet is currently limited to 10/100Mbps ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
