Hi Igor On Tue, Nov 19, 2013 at 9:24 AM, Igor Grinberg <grinb...@compulab.co.il> wrote: > Hi Michael, > > On 11/18/13 16:10, Michael Trimarchi wrote: >> Enable clocks for the peripherals only if they are used >> >> Signed-off-by: Michael Trimarchi <mich...@amarulasolutions.com> >> --- >> arch/arm/cpu/armv7/omap3/clock.c | 2 -- >> arch/arm/include/asm/arch-omap3/clock.h | 2 -- >> 2 files changed, 4 deletions(-) >> >> diff --git a/arch/arm/cpu/armv7/omap3/clock.c >> b/arch/arm/cpu/armv7/omap3/clock.c >> index 14fc7e8..1bc27bd 100644 >> --- a/arch/arm/cpu/armv7/omap3/clock.c >> +++ b/arch/arm/cpu/armv7/omap3/clock.c >> @@ -730,8 +730,6 @@ void per_clocks_enable(void) >> sr32(&prcm_base->fclken_cam, 0, 32, FCK_CAM_ON); >> sr32(&prcm_base->iclken_cam, 0, 32, ICK_CAM_ON); >> } >> - sr32(&prcm_base->fclken_per, 0, 32, FCK_PER_ON); >> - sr32(&prcm_base->iclken_per, 0, 32, ICK_PER_ON); > > Hmmm... > Am I missing something or is this change breaks boards that > currently rely on the peripheral clocks being enabled here? >
This change break boards that are not correctly configured. Michael >> >> sdelay(1000); >> } >> diff --git a/arch/arm/include/asm/arch-omap3/clock.h >> b/arch/arm/include/asm/arch-omap3/clock.h >> index be669c1..1912cc9 100644 >> --- a/arch/arm/include/asm/arch-omap3/clock.h >> +++ b/arch/arm/include/asm/arch-omap3/clock.h >> @@ -27,8 +27,6 @@ >> #define ICK_DSS_ON 0x00000001 >> #define FCK_CAM_ON 0x00000001 >> #define ICK_CAM_ON 0x00000001 >> -#define FCK_PER_ON 0x0003ffff >> -#define ICK_PER_ON 0x0003ffff >> >> /* Used to index into DPLL parameter tables */ >> typedef struct { >> > > -- > Regards, > Igor. -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot