On 14/01/14 22:55, Przemyslaw Marczak wrote:
> Hello,
> In case of discussion with Piotr Wilczek maybe it is better to make some
> changes in this patch.
>
> On 01/10/2014 03:31 PM, Przemyslaw Marczak wrote:
>> Config: CONFIG_MISC_INIT_R enables implementation of misc_init_r()
>> in common file::
>> - board/samsung/common/misc.c
>>
>> Signed-off-by: Przemyslaw Marczak <p.marc...@samsung.com>
>> Acked-by: Jaehoon Chung <jh80.ch...@samsung.com>
>> ---
>> Changes v2:
>> - change CONFIG_SAMSUNG to CONFIG_MISC_INIT_R
>>
>> Changes v3:
>> - fix merge conflict in board/samsung/common/Makefile
>>
>> Changes v4:
>> - none
>>
>> Changes v5:
>> - add acked-by
>>
>> board/samsung/common/Makefile | 1 +
>> board/samsung/common/misc.c | 14 ++++++++++++++
>> 2 files changed, 15 insertions(+)
>> create mode 100644 board/samsung/common/misc.c
>>
>> diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
>> index 22bd6b1..79547a3 100644
>> --- a/board/samsung/common/Makefile
>> +++ b/board/samsung/common/Makefile
>> @@ -8,6 +8,7 @@
>> obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
>> obj-$(CONFIG_THOR_FUNCTION) += thor.o
>> obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
>> +obj-$(CONFIG_MISC_INIT_R) += misc.o
> here change to:
> obj-y += misc.o
>
>>
>> ifndef CONFIG_SPL_BUILD
>> obj-$(CONFIG_BOARD_COMMON) += board.o
>> diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
>> new file mode 100644
>> index 0000000..3764d12
>> --- /dev/null
>> +++ b/board/samsung/common/misc.c
>> @@ -0,0 +1,14 @@
>> +/*
>> + * Copyright (C) 2013 Samsung Electronics
>> + * Przemyslaw Marczak <p.marc...@samsung.com>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +
>
> and here:
> #ifdef CONFIG_MISC_INIT_R
>
>> +/* Common for Samsung boards */
>> +int misc_init_r(void)
>> +{
>> + return 0;
>> +}
>>
> #endif
>
> In this way we can add other functions in the future even without
> CONFIG_MISC_INIT_R.
partly agree.
But, I doubt what is the role of misc.c file.
because of the meaning of miscellaneous is ambiguous,
this file have possibility to be messy.
So, please let me know what is your plan to this file.
>
> Is it better solution?
>
> Thank you,
Thanks,
Minkyu Kang.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
