On 01/17/2014 02:14 AM, Hector Palacios wrote: > Since function mmc_get_env_devno is __weak and can be overridden by > board code, boards do not need to mandatory define > CONFIG_SYS_MMC_ENV_DEV. > If the constant is not defined, define it to 0 by default.
> diff --git a/common/env_mmc.c b/common/env_mmc.c > +#if !defined(CONFIG_SYS_MMC_ENV_DEV) > +#define CONFIG_SYS_MMC_ENV_DEV 0 > +#endif > + > __weak int mmc_get_env_devno(void) > { > return CONFIG_SYS_MMC_ENV_DEV; > +} Oh, I guess your fixup got squashed into the wrong patch? Aside from that issue, and those Otavio raised, the series, Reviewed-by: Stephen Warren <swar...@nvidia.com> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot