On Monday, January 20, 2014 at 12:46:07 PM, Jagan Teki wrote: > On Mon, Jan 20, 2014 at 4:43 PM, Detlev Zundel <d...@denx.de> wrote: > > Hi Jagan, > > > >> On Sun, Jan 19, 2014 at 2:06 AM, Marek Vasut <ma...@denx.de> wrote: > >>> On Saturday, January 18, 2014 at 09:06:31 PM, Jagannadha > >>> Sutradharudu Teki > >>> > >>> wrote: > >>>> - Used readable names for read/write command macros > >>>> - Added comments for the same > >>>> > >>>> Signed-off-by: Jagannadha Sutradharudu Teki <jaga...@xilinx.com> > >>>> Cc: Marek Vasut <ma...@denx.de> > >>>> Cc: Simon Glass <s...@chromium.org> > >>> > >>> Does this patch have any impact other than making the code harder to > >>> understand > >>> ? :-( > >>> > >>> What's the rationale for making the code more cryptic ? > >> > >> No issues I guess with the readability as each macro we can easily > >> understand. > >> like CMD_RD_QUAD --> command_read_quad > >> > >> CMD_WR_PAGE --> command_write_page_program > >> > >> And this will minimize the macro length - good for in coding and more > >> over description is added in drivers/mtd/spi/sf_internal.h anyway. > > > > Again I agree with Marek that readability of code is more important than > > saving a few characters while coding. This is especially true as > > editors can support you in coding (Emacs has lots of packages to help > > here for example). > > I don't think nothing much gone the readability with these updated: > CMD_READ_ARRAY_FAST has updated CMD_RD_FAST and it seems like > easy to understand. and anyway I have added comments for full name as well.
CMD_READ_ARRAY_FAST contains all the necessary bits for me to understand what the macro means. CMD_RD_FAST does not. I fail to see the rationale behind changing the names. > Few of the flashes can be call this as array fast read and fewer call > this as fast read > and few more call this as high frequency read. CMD_RD_FAST will suits > all these names. > > Comments please! If you want to align the names with anything, align then with linux's m25p80.c driver . But I see this change as moot and confusing, sorry. Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot