Dear Murali Karicheri, In message <1390255810-19486-6-git-send-email-m-kariche...@ti.com> you wrote: > This patch introduces a configurable mechanism to disable subpage writes > in the DaVinci NAND driver. > > Signed-off-by: Vitaly Andrianov <vita...@ti.com> > Signed-off-by: Murali Karicheri <m-kariche...@ti.com> > --- > drivers/mtd/nand/davinci_nand.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 5b17d7b..75b03a7 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -609,6 +609,9 @@ void davinci_nand_init(struct nand_chip *nand) > #ifdef CONFIG_SYS_NAND_USE_FLASH_BBT > nand->bbt_options |= NAND_BBT_USE_FLASH; > #endif > +#ifdef CONFIG_SYS_NAND_NO_SUBPAGE_WRITE > + nand->options |= NAND_NO_SUBPAGE_WRITE; > +#endif > #ifdef CONFIG_SYS_NAND_HW_ECC > nand->ecc.mode = NAND_ECC_HW; > nand->ecc.size = 512;
New CONFIG_ options MUSt be documented in the README. Also, you are just adding dead code. There are no users for this option. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de While most peoples' opinions change, the conviction of their correct- ness never does. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot