On Fri, Jan 24, 2014 at 09:45:36AM +0100, Enric Balletbo Serra wrote: > Hi Tom, > > 2014/1/6 Tom Rini <tr...@ti.com>: > > On Mon, Dec 23, 2013 at 12:11:25PM +0100, Enric Balletbo Serra wrote: > >> 2013/12/6 Enric Balletbo i Serra <eballe...@gmail.com>: > >> > Hi all, > >> > > >> > Most of the boards based on TI processors uses common configuration files > >> > (ti_armv7_common.h, ti_<processor>_common.h) to avoid duplication of > >> > code. > >> > This is right except for OMAP3-based boards. In order to use the same > >> > schema > >> > as used on am33xx, omap4, omap5 and dra7 TI processors these patches > >> > create > >> > a new ti_omap3_common.h (that include ti_armv7_common.h) with the > >> > purpose that > >> > all OMAP3 board can use it. > >> > > >> > Patches 1 and 2 just renames current omap4|omap5_common.h to > >> > ti_omap4|omap5_common.h to be coherent with current ti_am33xx_common.h, > >> > ti_armv7_common.h and the new ti_omap3_common.h. It's just a cosmetic > >> > change so > >> > if people don't like it I don't have any inconvenient to remove from > >> > these > >> > series. > >> > > >> > Patches 3 and 4 modifies the ti_armv7_common.h to be more compatible > >> > with OMAP3 > >> > boards. For example, patch 3 removes the assumption that all ti_armv7 > >> > have an > >> > ELM hardware engine and patch 4 handles the case that the number of DRAM > >> > banks > >> > is defined at board level. The patch 5 is also required to integrate the > >> > use > >> > of ti_armv7_common.h on OMAP3 boards. > >> > > >> > Patch 6 creates the new ti_omap3_common.h to be used for any OMAP3-based > >> > board. > >> > > >> > And finally, patch 7 moves the IGEP boards to use the new common file. > >> > As I > >> > only have IGEP hardware to test these patches I decided only implement > >> > the use > >> > case for these boards. I don't have any inconvenient to move other OMAP3 > >> > boards > >> > to use this schema but I prefer leave the decision to the board > >> > maintainers. > >> > > >> > Any comments, improvements, fixes are welcome. > >> > > >> > Best regards, > >> > > >> > Enric Balletbo i Serra (7): > >> > ARM: OMAP4: Rename to ti_omap4_common.h > >> > ARM: OMAP5: Rename to ti_omap5_common.h > >> > TI: armv7: Move ELM support to SoC configuration file. > >> > TI: armv7: Do not define the number DRAM banks if is already defined. > >> > ARM: OMAP3: Rename OMAP3_PUBLIC_SRAM_* to NON_SECURE_SRAM_* > >> > TI: OMAP3: Create common config files for TI OMAP3 platforms. > >> > OMAP3: igep00x0: Convert to ti_omap3_common.h. > >> > > >> > arch/arm/include/asm/arch-omap3/omap3.h | 6 +- > >> > include/configs/dra7xx_evm.h | 4 +- > >> > include/configs/omap3_igep00x0.h | 190 > >> > +-------------------- > >> > include/configs/omap4_panda.h | 4 +- > >> > include/configs/omap4_sdp4430.h | 4 +- > >> > include/configs/omap5_uevm.h | 4 +- > >> > include/configs/ti_am335x_common.h | 4 + > >> > include/configs/ti_armv7_common.h | 11 +- > >> > include/configs/ti_omap3_common.h | 73 ++++++++ > >> > .../configs/{omap4_common.h => ti_omap4_common.h} | 10 +- > >> > .../configs/{omap5_common.h => ti_omap5_common.h} | 10 +- > >> > 11 files changed, 118 insertions(+), 202 deletions(-) > >> > create mode 100644 include/configs/ti_omap3_common.h > >> > rename include/configs/{omap4_common.h => ti_omap4_common.h} (95%) > >> > rename include/configs/{omap5_common.h => ti_omap5_common.h} (95%) > >> > >> Ping, any comment on this patch series ? > > > > I intend to pick this up after v2014.01. Thanks! > > > > Now that merge window is open, did you try to pick these patches?
I'm planning to today. > There is an issue that affect the IGEP boards introduced by commit > > commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d > arm: omap3: Enable clocks for peripherals only if they are used > > To fix the issue, I need to modify the omap3_igep00x0.h file and I'm > thinking that it's preferable wait and send the patch after these > patches. > > Also there is any plan to create a branch for 2014.01 with fixes ? Depends on how many other boards also need to re-enable some clocks I guess. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot