On Mon, Feb 17, 2014 at 11:56:36AM -0600, Dennis Gilmore wrote:
> Signed-off-by: Dennis Gilmore <den...@ausil.us>
[snip]
> + "if ${usb_need_init}; then " \
> + "set usb_need_init false; " \
> + "usb start 0; " \
Checking common/cmd_usb.c, 'start' doesn't take arguments.
> +#ifdef CONFIG_CMD_SATA
> +#define BOOTCMDS_SATA \
> + "sata_boot=" \
> + "setenv devtype sata; " \
> + "if sata dev ${devnum}; then " \
> + "run scan_boot; " \
> + "fi\0" \
> + \
> + "bootcmd_sata0=setenv devnum 0; run sata_boot;\0"
> + "bootcmd_sata1=setenv devnum 1; run sata_boot;\0"
> +#define BOOT_TARGETS_USB "sata0 sata1"
Typo, s/USB/SATA/
> +#ifdef CONFIG_CMD_DHCP
> +#define BOOTCMDS_DHCP \
> + "bootcmd_dhcp=" \
> + BOOTCMD_INIT_USB \
Why BOOTCMD_INIT_USB here? For USB based networking? If so, add some
comments please.
> + "if dhcp ${scriptaddr} boot.scr.uimg; then "\
> + "source ${scriptaddr}; " \
> + "fi\0"
This relies on autoload being true, so we should set that.
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
