Dear Stephen Warren, In message <5331a6b6.8090...@wwwdotorg.org> you wrote: > > > Or perhaps update_reg_mask_shift_val()? > > Still, I can rename the function if you want; it certainly does make it > obvious. It's rather a long name though, but I guess wrapping the > parameters isn't too bad.
Please do not invent new bit manipulation functions. Just use the standard I/O accessors. And whenever possible, please remove pre- existing functions. I've just recently sent patches to get rid of such "inventions" that resulted in undefined code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Faith: not *wanting* to know what is true." - Friedrich Nietzsche _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot