Hi Wolfgang, On Thursday 07 May 2009, Wolfgang Denk wrote: > > Perhaps it's quite new to the Linux kernel. I just spotted it the first > > time a few weeks ago and thought: "What a nice way to remove some of the > > ugly #ifdef's in U-Boot!". :) > > My understanding was that this is (only?) intended for function > declarations to silence warnings about unused function arguments > (which may be necessary anyway for compatible call interface with > other functions that actually need this arg).
No. This is not the case. Just take a look at the usage in drivers/net for example. You will see this construct is used here exactly to prevent those #ifdef's in the variable declaration in many cases: drivers/net/bnx2.c: int hw_vlan __maybe_unused = 0; ... #ifdef BCM_VLAN if (bp->vlgrp) hw_vlan = 1; else #endif But ok, if nobody else other than me prefers this version then I'll change to those #ifdef's again. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot