Dear Stefan, In message <200905110917.21667...@denx.de> you wrote: > > > +phys_size_t initdram (int board_type) > > +{ > > + u32 msize = 0; > > + > > + msize = fixed_sdram (); > > + > > + return msize; > > +} > > Or just: > > phys_size_t initdram (int board_type) > { > return fixed_sdram (); > }
Right, will change. > And I noticed that are mixing the coding style's in this file (space before > "(" of functions): fixed_sdram () vs. out_be(...). Better it would be > consistent. Indeed. Will change, too. Thanks for pointing out. [I'll continue to collect review comments for a few more days and then post patch series V2; in the meantime, the current, updated code, rebased against "next", is available in the "aria" branch of the u-boot-testing repository.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de There comes to all races an ultimate crisis which you have yet to face .... One day our minds became so powerful we dared think of ourselves as gods. -- Sargon, "Return to Tomorrow", stardate 4768.3 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot