Shinya Kuribayashi wrote:
> Thomas Lange (1):
> MIPS: Implement ethernet halt for au1x00
[...]
> diff --git a/cpu/mips/au1x00_eth.c b/cpu/mips/au1x00_eth.c
> index 6272a3a..5074997 100644
> --- a/cpu/mips/au1x00_eth.c
> +++ b/cpu/mips/au1x00_eth.c
> @@ -276,6 +276,10 @@ static int au1x00_init(struct eth_device* dev, bd_t *
> bd){
> }
>
> static void au1x00_halt(struct eth_device* dev){
> + volatile u32 *macen = (volatile u32*)MAC0_ENABLE;
> +
> + /* Put MAC0 in reset */
> + *macen = 0;
> }
>
> int au1x00_enet_initialize(bd_t *bis){
>From the CodingStyle point of view, (volatile u32 *) is preferred,
but I see that Thomas-san just follow existing code and tries to be
consistent.
Wolfgang-san, I hope the patch is applied as-is at this moment, and
look forward to cleanup patch in the future.
Thanks in advance,
Shinya
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
