On 16:16 Fri 15 May , Tom wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 16:28 Thu 07 May , Tom Rix wrote:
>>
>>> Zoom2 serial is in general supplied by one of the 4 UARTS on the debug
>>> board.
>>> The default serial is from the USB connector on left side of the debug
>>> board.
>>>
>>> +/*
>>> + * This the the zoom2, board specific, gpmc configuration for the
>>> + * quad uart on the debug board. The more general gpmc configurations
>>> + * are setup at the cpu level in cpu/arm_cortexa8/omap3/mem.c
>>> + */
>>> +extern void enable_gpmc_config(u32 *gpmc_config, gpmc_csx_t *gpmc_cs_base,
>>> + u32 base, u32 size);
>>> +
>>> +static u32 gpmc_serial_TL16CP754C[GPMC_MAX_REG] = {
>>> + 0x00011000,
>>> + 0x001F1F01,
>>> + 0x00080803,
>>> + 0x1D091D09,
>>> + 0x041D1F1F,
>>> + 0x1D0904C4, 0
>>> +};
>>>
>> Any chance to have comment at least about these value?
>>
>
> I have not gotten a response for a better comment.
>
> Can I have a pass on this ?
ok but add a comment in the code and the commit to explain why you can not
provide comment about these values
Best Regards,
J.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
