Hi Stephen, On 15 August 2014 11:10, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 08/11/2014 09:27 AM, Simon Glass wrote: >> >> Some Tegra device tree files do not include information about the serial >> ports. Add this and also add information about the input clock speed. >> >> The console alias needs to be set up to indicate which port is used for >> the console. >> >> Also add a binding file since this is missing. > > >> diff --git a/arch/arm/dts/tegra114-dalmore.dts >> b/arch/arm/dts/tegra114-dalmore.dts > > >> aliases { >> + console = &uart_d; > > > Did the use of "console" get OK'd on the devicetree mailing list then?
No, not yet. I copied on you the thread. I'm not necessarily expecting a response. > > I know we have this bug in the kernel DTs, but let's fix it here: phandle > values should have <> around them: > > console = <&uart_d>; This is not a phandle though. Are you wanting to change that? > >> diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi > > >> + uart_a: serial@70006000 { >> + compatible = "nvidia,tegra20-uart"; >> + reg = <0x70006000 0x40>; >> + reg-shift = <2>; >> + interrupts = < 68 >; >> + }; > > > In order to prevent the kernel and U-Boot DT files from diverging, can you > copy the entire DT content from the kernel rather than just a subset, i.e.: > > uarta: serial@70006000 { > compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart"; > > reg = <0x70006000 0x40>; > reg-shift = <2>; > interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&tegra_car TEGRA114_CLK_UARTA>; > resets = <&tegra_car 6>; > reset-names = "serial"; > dmas = <&apbdma 8>, <&apbdma 8>; > dma-names = "rx", "tx"; > status = "disabled"; > }; OK, that's probably a good idea even if U-Boot doesn't use it. Will need the include files also. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot