On Friday, September 05, 2014 at 07:50:19 AM, Masahiro Yamada wrote:
> The driver for on-chip UART used on Panasonic UniPhier platform.
>
> Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com>
[...]
Hi!
> +static void uniphier_serial_putc(struct uniphier_serial *port, const char
> c) +{
> + if (c == '\n')
> + uniphier_serial_putc(port, '\r');
Just curious, but what is the concensus about inserting \r upon \n ? Shouldn't
this be something that the "upper layers" do consistently ? I recall seeing
this
in some drivers and not seeing this in the others, so I wonder why this is like
so ...
> + while (!(readb(&port->lsr) & UART_LSR_THRE))
> + ;
> +
> + writeb(c, &port->thr);
> +}
[...]
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
