> -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:[email protected]] > Sent: Saturday, May 30, 2009 3:52 AM > To: Prafulla Wadaskar > Cc: [email protected]; Manas Saksena; Ronen Shitrit; > Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek > Subject: Re: [U-Boot] [PATCH] arm: Kirkwood: Basic SOCs support > > > + * > > + * Reference Documentation: > > + * Mbus-L to Mbus Bridge Registers Configuration. > > + * (Sec 25.1 and 25.3 of Datasheet) > > + */ > > +int kw_config_adr_windows(void) > > +{ > > + struct kwwin_registers *winregs = > > + (struct kwwin_registers *)KW_CPU_WIN_BASE; > > + > > + writel(KWCPU_WIN_CTRL_DATA(0xc0000, KWCPU_TARGET_PCIE, > > + KWCPU_ATTR_PCIE_MEM, KWCPU_WIN_ENABLE), > > + &winregs[0].ctrl); > > + > > + writel(0x90000000, &winregs[0].base); > any chance to have some macro for the 0x90000000 & co... Hi Jean, Base address, remap address high, remap address low are the registers need to be programmed with some address value. Making it macro will not make much sense since the code line itself is readable for objective > > other fine Please make it everything fine :-) Waiting eagerly for acceptance
Regards.. Prafulla .. > > Best Regards, > J. > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
