On Monday, September 22, 2014 at 11:16:04 AM, Pavel Machek wrote:
> On Sun 2014-09-21 15:12:12, Marek Vasut wrote:
> > Make the function return either 0 or -EINVAL, that is, normal
> > expected error codes and success codes instead of true/false
> > nonsense.
> >
> > Signed-off-by: Marek Vasut <ma...@denx.de>
> > Cc: Chin Liang See <cl...@altera.com>
> > Cc: Dinh Nguyen <dingu...@altera.com>
> > Cc: Albert Aribaud <albert.u.b...@aribaud.net>
> > Cc: Tom Rini <tr...@ti.com>
> > Cc: Wolfgang Denk <w...@denx.de>
>
> Acked-by: Pavel Machek <pa...@denx.de>
>
> > @@ -133,7 +133,7 @@ int altera_info(Altera_desc *desc)
> >
> > {
> >
> > int ret_val = FPGA_FAIL;
> >
> > - if (!altera_validate (desc, (char *)__func__)) {
> > + if (altera_validate (desc, (char *)__func__)) {
>
> + if (altera_validate(desc, (char *)__func__)) {
>
> You have extra space there, checkpatch would be angry.
I'm sure it will, but this was resolved somewhere down the patch stack. The
final result doesn't have this warning.
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
