Dear Riverful, In message <b64afca20906010014r321bd3fas3539d97f6667e...@mail.gmail.com> you wrote: > > Jean's opinion seems that file naming & func naming must match > for soruce maintaining, & definitely I agree with that.
I do not agree. Yes, they _should_ match. That means we should try to acchieve this whenever it makes sense. But there is no strict must that we need to create a new source file for each and every function. Maintaining tons of tiny files does not make much sense either. In this case, I agree with Dirk that splitting of a new source file for a small (10 lines or so including comments) function is overkill. Jean-Christiphe sent a note about this code, and Dirk probvided a reasonable explanation why the code was written as is. I think that should be enough in this case. From my point of view, the code can go in as is. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The algorithm to do that is extremely nasty. You might want to mug someone with it." - M. Devine, Computer Science 340 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot