On Thu, Oct 09, 2014 at 05:12:03PM +0200, Marek Vasut wrote: > On Thursday, October 09, 2014 at 08:18:14 AM, Simon Glass wrote: > > Hi, > > > > On 20 September 2014 08:54, Hans de Goede <hdego...@redhat.com> wrote: > > > In some cases we really want to move forward with a deregister, add a > > > force parameter to allow this, and replace the dev with a nulldev in > > > this case. > > > > > > Signed-off-by: Hans de Goede <hdego...@redhat.com> > > [...] > > > > diff --git a/drivers/serial/serial-uclass.c > > > b/drivers/serial/serial-uclass.c index d04104e..61cbdc6 100644 > > > --- a/drivers/serial/serial-uclass.c > > > +++ b/drivers/serial/serial-uclass.c > > > @@ -197,7 +197,7 @@ static int serial_pre_remove(struct udevice *dev) > > > > > > #ifdef CONFIG_SYS_STDIO_DEREGISTER > > > > > > struct serial_dev_priv *upriv = dev->uclass_priv; > > > > > > - if (stdio_deregister_dev(upriv->sdev)) > > > + if (stdio_deregister_dev(upriv->sdev), 0) > > > > That bracket seems to be in a strange place. > > Good find, thanks! I have two questions: > 1) How come I did not notice this and my build didn't spit?
Because only sandbox uses this right now I think. But I'm unhappy that I can't seem to make repeated runs of: $ ./tools/buildman/buildman -b master -c 1 -ve -T 1 -j 9 \ 'arc|blackfin|microblaze|m68k|nds32|sparc|x86|aarch64|sandbox|mips|avr32|arm|powerpc' $ ./tools/buildman/buildman -b master -c 1 -ve -T 1 -j 9 \ 'arc|blackfin|microblaze|m68k|nds32|sparc|x86|aarch64|sandbox|mips|avr32|arm|powerpc' \ -svel Show me just new problems from the last time I did it. I must be doing something wrong, Simon? -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot