On Mon, Oct 13, 2014 at 3:56 AM, Alban Bedel <alban.be...@avionic-design.de> wrote: > > On Thu, 9 Oct 2014 17:17:00 +0200 > Marek Vasut <ma...@denx.de> wrote: > > > On Thursday, October 09, 2014 at 01:42:49 PM, Alban Bedel wrote: > > > Many ethernet devices use an EEPROM to store various settings, most > > > commonly the device MAC address. But on some devices it can contains > > > a lot more, for example USB device might also have many USB related > > > parameters. > > > > > > This commit add a set of commands to read/write this EEPROM, write a > > > default configuration and read/write the device MAC address. The > > > defaults command allow priming the EEPROM for devices that need more > > > than just a MAC address in the EEPROM. > > > > > > Signed-off-by: Alban Bedel <alban.be...@avionic-design.de> > > > > I will not comment on the code yet, but would like to discuss the concept > > instead. I wonder, can we not have a more generic command here? One which > > can manage the ethernet device altogether, not just adjust it's eeprom? > > Something like 'ethtool' in Linux ... > > > > What do you think please ? > > Currently this is all I need for the boards I'm working on. However I > have no problem with splitting the command from 'eth_eeprom' to > 'eth eeprom' to leave room for other stuff.
I agree that the command would be better if it was "eth eeprom" -Joe
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
