On Fri, Jun 05, 2009 at 10:44:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > This adds generic bit operations for all platforms and enables includes > > the implementations from asm-arm. > > > > Code taken from Linux kernel. > > > the __set_bit, __clear_bit, __change_bit & co generic is used on arm ok
Do you mean it worked before? Or are you referring to the version I posted which you think is ok? > but be aware that we use it in U-Boot so NACK You use what? The functions I removed? I doubt that. The functions marked 'external' have no implementation, and I also don't believe the static inlines did the right thing (note the shift operations). > and please do not rename __xxx by xxx they do not mean the same think > > the __xxx can be re-ordered and the xxx not Sorry, I don't get it - what's your point about the status quo in the sources and about the patches? Daniel _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
