Dear Magnus Lilja, In message <ed0be9732183579c15279ba61413d3f3dc7155f8.1244572159.git.lilja.mag...@gmail.com> you wrote: > Add support for Freescale's i.MX31 PDK board (a.k.a. 3 stack board). > > This patch assumes that some other program performs the actual > NAND boot. > > Signed-off-by: Magnus Lilja <lilja.mag...@gmail.com> > --- ... > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -527,6 +527,10 @@ Thomas Elste <i...@elste.org> > > modnet50 ARM720T (NET+50) > > +Fabio Estevam <fabio.este...@freescale.com> > + > + mx31pdk i.MX31 > + > Peter Figuli <pep...@etc.sk>
Is this correct? It's quite unusal that somebody becomes maintainer of a port who seems to have not been involved with it at all - at least I cannot see his name in any of the Signed-off-by lines nor in any (C) lines or anywhere else? Fabio, do you agree? ... > +int board_init(void) > +{ > + /* CS5: CPLD incl. network controller */ > + __REG(CSCR_U(5)) = 0x0000d843; > + __REG(CSCR_L(5)) = 0x22252521; > + __REG(CSCR_A(5)) = 0x22220a00; > + > + /* Setup UART1 and SPI2 pins */ > + mx31_uart1_hw_init(); > + mx31_spi2_hw_init(); > + > + gd->bd->bi_arch_number = MACH_TYPE_MX31_3DS; /* board id for linux */ Hm... that's the MACH ID for the Freescale MX31_3DS board. You are talking about PDK instead. Are these two really the same? > + gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100; > + > + return 0; > +} > + > +int checkboard(void) > +{ > + printf("Board: i.MX31 MAX PDK (3DS)\n"); It seems they are the same? > +/* Disabled due to compilation errors in cmd_bootm.c (IMLS seems to require > + * that CFG_NO_FLASH is undefined). > + */ Incorrect multiline comment style. > +#define CONFIG_ENV_IS_NOWHERE 1 Why don't you put the environment in NAND? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Life. Don't talk to me about life. - Marvin the Paranoid Android _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot