Hi Stefano, On Wed, Nov 12, 2014 at 6:19 AM, Stefano Babic <sba...@denx.de> wrote:
> Generally, I do not find a good idea to overwrite the environment in > code. A user (I mean, a developer) becomes crazy if the environment he > has previously set with "setenv" and "saveenv" has no worth, because > some part of code has overwritten. Let's think to a developer working > with kernel and not with U-Boot, and he has several DTB, depending on > what he want to do. You bring a good point and I also agree that in general we should avoid 'setenv' inside the code. > Anyway, I understand that this helps for a ready-to-use board. I won't > NACK the patch, and you as maintainer of the board are in the best > position to decide, but I want only to ask you what do you think in such > as a case before applying. Yes, the idea here was that U-boot could retrieve the correct dtb automatically for the two board revisions and provide a better user experience. Thanks, Fabio Estevam _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot