On Sun, 2014-11-16 at 11:35 +0000, Ian Campbell wrote: > On Fri, 2014-11-14 at 17:54 +0100, Hans de Goede wrote: > > +/* this is needed so the above will actually do something */ > > +#define CONFIG_SYS_CONSOLE_IS_IN_ENV > > [...] > > +#ifdef CONFIG_VIDEO > > +#define CONSOLE_ENV_SETTINGS \ > > + "stdin=serial\0" \ > > + "stdout=serial,vga\0" \ > > + "stderr=serial,vga\0" > > +#else > > +#define CONSOLE_ENV_SETTINGS > > Now that CONFIG_SYS_CONSOLE_IS_IN_ENV is set do we need to either say > something here and/or provide the overwrite_console() hook? > > Perhaps something along the lines of: > #ifdef CONFIG_VIDEO > #define CONSOLE_ENV_VGA_SETTINGS ",vga" > #endif > > #define CONSOLE_ENV_SETTINGS \ > "stdin=serial\0" \ > "stdout=serial" CONSOLE_ENV_VGA_SETTINGS "\0" \ > "stderr=serial" CONSOLE_ENV_VGA_SETTINGS "\0" > > Has this been tested on a serial-only board?
Forgot to say: all the rest looks fine to me and/or I'm satisfied if Anatolij is. Ian _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot