Jean-Christophe PLAGNIOL-VILLARD wrote: >> How about this: >> >> Regarding Dirk's and Heiko's comment: >> A) How about board/omap3/common/power.c to drivers/power/twl4030.c >> > Ack > but I've a patch for Dirk in my queued that I need to process about it > so we have 2 choice > 1) apply Dirk's patch first and the move the code to drivers/power > 2) rewrite a patch against the next > > Please forward me the patch, I will merge it into the drivers/power/twl4030.c I am creating. > I've in mind to do the 1) to mention in the changelog Dirk's work > >> On patch [PATCH 2/4] I2C Add initial support for TWL4030: >> B) introduce a new header in include/twl4030.h from Tom's patch >> Remove drivers/i2c/twl4030_i2c.c from the patch instead add: >> #define TWLL4030_READ_U8(MODULE, VAL,REG)\ >> i2c_read((MODULE), (REG), 1, (VAL), 1) >> #define TWLL4030_WRITE_U8(MODULE, VAL,REG)\ >> i2c_read((MODULE), (REG), 1, (VAL), 1) >> to include/twl4030.h in the patch. >> > please use inline function for this > > Yes. I am doing adding this to twl4030.h
static inline int twl4030_i2c_read_u8(u8 chip_no, u8 *val, u8 reg) {} > Best Regards, > J. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot