Hi,

On 18-12-14 19:59, Ian Campbell wrote:
On Wed, 2014-12-17 at 13:56 +0100, Hans de Goede wrote:
@@ -128,7 +128,8 @@
   #define SUN6I_CPUCFG_BASE              0x01f01c00
   #define SUNXI_R_UART_BASE              0x01f02800
   #define SUNXI_R_PIO_BASE               0x01f02c00
-#define SUNXI_P2WI_BASE                        0x01f03400
+#define SUNXI_P2WI_BASE                        0x01f03400      /* on sun6i */
+#define SUNXI_RSB_BASE                 0x01f03400      /* on sun8i */

Maybe we just use SUN6I_ SUN8I_ prefixes?
The base address will be different on sun9i.

Did you miss this suggestions from Chen-Yu? Seems like a good one.

Yes I missed that (must have read over it). That will work for P2Wi,
but not for RSB, as RSB is used on the A80 too AFAIK, but I guess having
P2WI as SUN6I and RSB as SUNXI makes it clear what is used where, so
I'll update the patch with that change.

Regards,

Hans
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to