Hi Igor, On 23 December 2014 at 23:53, Igor Grinberg <grinb...@compulab.co.il> wrote: > Hi Simon, > > On 12/23/14 21:04, Simon Glass wrote: >> We need to get rid of this SPL-specific setting of the global_data pointer. >> It is already set up in start.S immediately before board_init_f() is called, >> and there may be information there that is needed (e.g. pre-reloc malloc >> info). >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> --- >> >> arch/arm/lib/spl.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/lib/spl.c b/arch/arm/lib/spl.c >> index dfcc596..c41850a 100644 >> --- a/arch/arm/lib/spl.c >> +++ b/arch/arm/lib/spl.c >> @@ -15,6 +15,11 @@ >> >> /* Pointer to as well as the global data structure for SPL */ >> DECLARE_GLOBAL_DATA_PTR; >> + >> +/* >> + * WARNING: This is going away very soon. Don't use it and don't submit >> + * pafches that rely on it. The global_data area is set up in crt0.S. >> + */ >> gd_t gdata __attribute__ ((section(".data"))); >> >> /* >> @@ -28,7 +33,7 @@ void __weak board_init_f(ulong dummy) >> /* Clear the BSS. */ >> memset(__bss_start, 0, __bss_end - __bss_start); >> >> - /* Set global data pointer. */ >> + /* TODO: Remove settings of the global data pointer here */ > > Why do you need this patch at all if you remove this stuff in 9/9?
I imagine that 9/9 might take some time to be applied, since it needs testing, so I've put that in as a clean-up patch. > >> gd = &gdata; >> >> board_init_r(NULL, 0); Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot