> -----Original Message----- > From: Tom Rix [mailto:tom....@windriver.com] > Sent: Thursday, June 18, 2009 11:14 PM > To: u-boot@lists.denx.de; Menon, Nishanth; dirk.be...@googlemail.com > Cc: Tom Rix > Subject: [PATCH 2/3] I2C Add initial support for TWL4030 > > +++ b/include/twl4030.h <snip> > +/* POWER */ > +#define TWL4030_CHIP_BACKUP 0x4b > +#define TWL4030_CHIP_INT 0x4b > +#define TWL4030_CHIP_PM_MASTER 0x4b > +#define TWL4030_CHIP_PM_RECEIVER 0x4b > +#define TWL4030_CHIP_RTC 0x4b > +#define TWL4030_CHIP_SECURED_REG 0x4b > + > +/* Register base addresses */ > + > +/* USB */ > +#define TWL4030_BASEADD_USB 0x0000 > +/* AUD */ > +#define TWL4030_BASEADD_AUDIO_VOICE 0x0000 > +#define TWL4030_BASEADD_GPIO 0x0098 > +#define TWL4030_BASEADD_INTBR 0x0085 > +#define TWL4030_BASEADD_PIH 0x0080 > +#define TWL4030_BASEADD_TEST 0x004C > +/* AUX */ > +#define TWL4030_BASEADD_INTERRUPTS 0x00B9 > +#define TWL4030_BASEADD_LED 0x00EE > +#define TWL4030_BASEADD_MADC 0x0000 > +#define TWL4030_BASEADD_MAIN_CHARGE 0x0074 <snip>
> +static inline int twl4030_i2c_write_u8(u8 chip_no, u8 val, u8 reg) > +{ Could you add a little more documentation what I should use for chip_no etc? My main problem when I think as a first time looker, is trying to understand Which #defines should I be using where? I really do not want to see half a dozen repeated emails on the list asking for this info <snip> Regards, Nishanth Menon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot