On Thu, 2015-01-15 at 15:52 +0100, Hans de Goede wrote:
> The clocks on the A80 are hooked up slightly different, add support for this.
> 
> Signed-off-by: Hans de Goede <hdego...@redhat.com>

Acked-by: Ian Campbell <i...@hellion.org.uk>

Couple of minor comments:

> ---
>  arch/arm/include/asm/arch-sunxi/mmc.h |  5 ++++-
>  drivers/mmc/sunxi_mmc.c               | 14 ++++++++++++--
>  2 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-sunxi/mmc.h 
> b/arch/arm/include/asm/arch-sunxi/mmc.h
> index 537f145..0120045 100644
> --- a/arch/arm/include/asm/arch-sunxi/mmc.h
> +++ b/arch/arm/include/asm/arch-sunxi/mmc.h
> @@ -43,7 +43,7 @@ struct sunxi_mmc {
>       u32 chda;               /* 0x90 */
>       u32 cbda;               /* 0x94 */
>       u32 res1[26];
> -#if defined(CONFIG_MACH_SUN6I) || defined(CONFIG_MACH_SUN8I)
> +#if defined(CONFIG_MACH_SUN6I) || defined(CONFIG_MACH_SUN8I) || 
> defined(CONFIG_MACH_SUN9I)
>       u32 res2[64];
>  #endif
>       u32 fifo;               /* 0x100 (0x200 on sun6i) FIFO access address */

This comment is now two generations behind.

[...]

> -#if defined(CONFIG_MACH_SUN6I) || defined(CONFIG_MACH_SUN7I) || 
> defined(CONFIG_MACH_SUN8I)
> +#if defined(CONFIG_MACH_SUN6I) || defined(CONFIG_MACH_SUN7I) || 
> defined(CONFIG_MACH_SUN8I) || defined(CONFIG_MACH_SUN9I)

Can you wrap this a bit please (and perhaps run checkpatch.pl in case
there are more which my eye wasn't drawn too).

Ian.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to