Hi Hans, On 19 January 2015 at 12:06, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > > On 18-01-15 04:12, Simon Glass wrote: >> >> Hi Hans, >> >> On 13 January 2015 at 04:33, Hans de Goede <hdego...@redhat.com> wrote: >>> >>> While running some tests with an Olinuxino-A13-Micro + a 7" Olimex LCD >>> module >>> I noticed that the screen flickered. This is caused by the lcd display >>> clk >>> phase reg value being set to 0, where it should be 1 in this setup. >>> >>> This commit adds a Kconfig option for the lcd display clk phase, so that >>> we >>> can set it per board. This defaults to 1, because looking at all the fex >>> files in sunxi-boards, that is by far the most used value. >>> >>> This commit updated the Ippo and MSI Primo73 tablet defconfigs to >>> override the >>> default of 1 with 0, as that is the correct value for those tablets, this >>> keeps the register settings the same as before this commit. >>> >>> The Olinuxino-A13 defconfigs are not updated, changing the register >>> setting >>> for these boards from 0 to 1, this is intentional. >>> >>> Signed-off-by: Hans de Goede <hdego...@redhat.com> >>> --- >>> arch/arm/include/asm/arch-sunxi/display.h | 4 +--- >>> board/sunxi/Kconfig | 7 +++++++ >>> configs/Ippo_q8h_v1_2_defconfig | 1 + >>> configs/Ippo_q8h_v5_defconfig | 1 + >>> configs/MSI_Primo73_defconfig | 1 + >>> drivers/video/sunxi_display.c | 7 +------ >>> 6 files changed, 12 insertions(+), 9 deletions(-) >> >> >> Are you planning to move this to device tree at some point? > > > Yes, one of the free-electrons guys is working on a kms driver, once we've > that > and thus stable devicetree bindings for the display blocks I want to move > all > this over to devicetree.
OK thanks. More generally for sunxi I am wondering how common the board code can be. Already you have managed to support all sun7i boards in essentially a single config, for example. I wonder if we might support all sun7i boards with just different device trees? Not sure about other variants? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot