On Tue, Mar 03, 2015 at 08:03:00AM -0700, Simon Glass wrote: > At present SPL uses a single stack, either CONFIG_SPL_STACK or > CONFIG_SYS_INIT_SP_ADDR. Since some SPL features (such as MMC and > environment) require a lot of stack, some boards set CONFIG_SPL_STACK to > point into SDRAM. They then set up SDRAM very early, before board_init_f(), > so that the larger stack can be used. > > This is an abuse of lowlevel_init(). That function should only be used for > essential start-up code which cannot be delayed. An example of a valid use is > when only part of the SPL code is visible/executable, and the SoC must be set > up so that board_init_f() can be reached. It should not be used for SDRAM > init, console init, etc. > > Add a CONFIG_SPL_STACK_R option, which allows the stack to be moved to a new > address before board_init_r() is called in SPL. > > The expected SPL flow (for CONFIG_SPL_FRAMEWORK) is documented in the README. > > Signed-off-by: Simon Glass <s...@chromium.org> > For version 1: > Acked-by: Albert ARIBAUD <albert.u.b...@aribaud.net> > Reviewed-by: Stefan Roese <s...@denx.de> > Tested-by: Bo Shen <voice.s...@atmel.com> > Acked-by: Bo Shen <voice.s...@atmel.com> > Acked-by: Heiko Schocher <h...@denx.de> > Tested-by: Heiko Schocher <h...@denx.de>
After fixing the Kconfig part to not have 'CONFIG_' in the 'config' and 'depends' lines, applied to u-boot/master, thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
