Hi Andrey,

On 03/14/2015 12:49 AM, Andrey Danin wrote:
Main reason for this patches is ability to use bootmenu
on devices that use lcd driver (like Toshiba AC100).

Lcd driver doesn't have ansi support while cfb_console does.
Ansi related code was moved from cfb_console to separate place.
Then this code was used in both cfb_console and lcd driver.

There are other duplicated code between cfb_console and lcd.

I'm not very experienced with video subsystem. Maybe there is a
better/more proper way to add ansi support for Toshiba AC100.

I think you have the right idea. As you pointed out, there's a lot of
duplication between lcd code and video code which should be eliminated,
and this is a step in that direction.

Hannes Petermaier is currently also working on lcd console functionality
(Introduce lcd_console rotation), and I recommend that you sync with his
patches (V2 has just been posted).


---

Andrey Danin (4):
   common: add ansi console base implementation
   video: cfb_console: use common ansi implementation
   lcd: use ansi console
   paz00: enable bootmenu

  common/Makefile             |   2 +-
  common/ansi_console.c       | 355 +++++++++++++++++++++++++++++++++++++++++
  common/lcd.c                |  24 ---
  common/lcd_console.c        | 122 ++++++++------
  drivers/video/Makefile      |   2 +-
  drivers/video/cfb_console.c | 381 ++++----------------------------------------
  include/ansi_console.h      |  39 +++++
  include/configs/paz00.h     |   5 +
  include/lcd_console.h       |  33 ++++
  9 files changed, 537 insertions(+), 426 deletions(-)
  create mode 100644 common/ansi_console.c
  create mode 100644 include/ansi_console.h


--
Regards,
Nikita Kiryanov
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to