Hi! > >> +#define \ > >> +SDR_CTRLGRP_MPTHRESHOLDRST_0_THRESHOLDRSTCYCLES_31_0_LSB 0 > >> +#define \ > >> +SDR_CTRLGRP_MPTHRESHOLDRST_0_THRESHOLDRSTCYCLES_31_0_MASK \ > >> +0xffffffff > >> +/* Register template: sdr::ctrlgrp::mpthresholdrst::mpthresholdrst_1 > >> */ > >> +#define \ > >> +SDR_CTRLGRP_MPTHRESHOLDRST_1_THRESHOLDRSTCYCLES_63_32_LSB 0 > >> +#define \ > >> +SDR_CTRLGRP_MPTHRESHOLDRST_1_THRESHOLDRSTCYCLES_63_32_MASK \ > >> +0xffffffff > >> +/* Register template: sdr::ctrlgrp::mpthresholdrst::mpthresholdrst_2 > >> */ > >> +#define \ > >> +SDR_CTRLGRP_MPTHRESHOLDRST_2_THRESHOLDRSTCYCLES_79_64_LSB 0 > >> +#define \ > >> +SDR_CTRLGRP_MPTHRESHOLDRST_2_THRESHOLDRSTCYCLES_79_64_MASK \ > >> +0x0000ffff > > > > Can we get slightly shorter define names? > > I did think about shortening these defines a bit, but came to this > reason that I should leave these alone. These defines are generated from > the tools AFAICT. I don't think any sane person would try to have > defines this long. So I still want to try to save the use case that the > driver can still be used with the autogenerated header file from the > tools in some form.
Ok. [I'd suggest placing the defines on single lines, ignoring 80 column rule, but then checkpatch would scream, so I guess it is ok as it is.] Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot